RFR: 8364128: Improve gathering of cpu feature names using stringStream [v4]

[Ashutosh Mehra]

On Tue, 5 Aug 2025 14:08:54 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More compile failure fix
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> This looks good to me! Added a few comments on the `join` method.

@jdksjolen new commit pushed to address your comments.

> src/hotspot/share/utilities/ostream.hpp line 170:
> 
>> 168: 
>> 169:    // Append strings returned by gen, separating each with separator.
>> 170:    // Stops when gen returns null or when buffer is out of space.
> 
> We never really stop when the buffer runs out of space.

Updated the comment.

> src/hotspot/share/utilities/ostream.hpp line 181:
> 
>> 179:        str = gen();
>> 180:      }
>> 181:      return;
> 
> Let's delete this return

Done

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26515#issuecomment-3156103224
PR Review Comment: https://git.openjdk.org/jdk/pull/26515#discussion_r2254997542
PR Review Comment: https://git.openjdk.org/jdk/pull/26515#discussion_r2254997589