RFR: 8357086: os::xxx functions returning memory size should return size_t [v24]

David Holmes dholmes at openjdk.org
Wed Aug 6 12:11:10 UTC 2025


On Wed, 6 Aug 2025 09:22:33 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> The assert should go after the syscall that we don't expect to fail, but which we have to tolerate the possibility of failing. That is the place where we can also report why the call failed.
>> 
>> I'm not sure what you mean about changing the usage pattern.
>
> What I meant is that in this PR we are focusing on adding a mechanism to indicate that something failed, not on reporting why that fail. 
> 
> Addressed as suggested.

If we are going to assert on failure then we should report as much information about the failure as possible.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2256943006


More information about the hotspot-dev mailing list