RFR: 8364128: Improve gathering of cpu feature names using stringStream [v5]
Ashutosh Mehra
asmehra at openjdk.org
Wed Aug 6 14:05:08 UTC 2025
On Tue, 5 Aug 2025 18:08:22 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:
>> This PR implements the code for cpu features names string using ~FormatBuffer~ stringStream. ~It also improves and extends FormatBuffer with an additional method that appends comma separated strings to the buffer.~ It also adds a method to stringStream that that appends separated strings separated by a delimiter to the buffer. This is useful in creating the cpu features names string.
>> This code will also be useful in Leyden to implement cpu feature check for AOTCodeCache [0].
>> Platforms affected: x86-64 and aarch64
>> Other platforms can be done if and when Leyden changes are ported to them.
>>
>> [0] https://github.com/openjdk/leyden/pull/84
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review comments
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
Can I get one more review of this please.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26515#issuecomment-3160311221
More information about the hotspot-dev
mailing list