RFR: 8364819: Post-integration cleanups for JDK-8359820 [v3]

[Aleksey Shipilev]

On Wed, 6 Aug 2025 14:06:19 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> Hi, please consider the following changes:
>> 
>> This is a cleanup after https://github.com/openjdk/jdk/pull/26309
>> 
>> 1) `_handshake_timed_out_thread `and `_safepoint_timed_out_thread` are now `Thread*` and not `intptr_t`, no conversions `p2i <-> i2p` needed.
>> 
>> 2) Added a missed brace in the error message. 
>> 
>> Trivial change.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8364819: Made handling of timed out thread safe

Comments...

src/hotspot/share/utilities/vmError.hpp line 229:

> 227:   static void set_safepoint_timed_out_thread(Thread* thread);
> 228:   static volatile Thread* get_handshake_timed_out_thread();
> 229:   static volatile Thread* get_safepoint_timed_out_thread();

`static volatile` for method declarations makes no real  sense? Just `static` would suffice.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26656#pullrequestreview-3092817846
PR Review Comment: https://git.openjdk.org/jdk/pull/26656#discussion_r2257319054