RFR: 8364819: Post-integration cleanups for JDK-8359820 [v4]

[Anton Artemov]

On Wed, 6 Aug 2025 21:02:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8364819: Fixed volatility issue on getters.
>
> src/hotspot/share/utilities/vmError.cpp line 108:
> 
>> 106: const intptr_t    VMError::segfault_address = pd_segfault_address;
>> 107: Thread* volatile VMError::_handshake_timed_out_thread = nullptr;
>> 108: Thread* volatile VMError::_safepoint_timed_out_thread = nullptr;
> 
> `volatile` is still not useful or needed here.

Removed.

> src/hotspot/share/utilities/vmError.cpp line 1346:
> 
>> 1344: 
>> 1345: void VMError::set_safepoint_timed_out_thread(Thread* thread) {
>> 1346:   Atomic::release_store(&_safepoint_timed_out_thread, thread);
> 
> Acquire/release is not what is needed here. You are not trying to synchronize with previous memory accesses. If you want to force this to be visible to the other thread a `fence()` is required.

Yes, that is what we want, thanks. Addressed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26656#discussion_r2259389904
PR Review Comment: https://git.openjdk.org/jdk/pull/26656#discussion_r2259389450