RFR: 8364819: Post-integration cleanups for JDK-8359820 [v5]
Aleksey Shipilev
shade at openjdk.org
Thu Aug 7 12:56:17 UTC 2025
On Thu, 7 Aug 2025 07:34:50 GMT, Anton Artemov <duke at openjdk.org> wrote:
>> Hi, please consider the following changes:
>>
>> This is a cleanup after https://github.com/openjdk/jdk/pull/26309
>>
>> 1) `_handshake_timed_out_thread `and `_safepoint_timed_out_thread` are now `Thread*` and not `intptr_t`, no conversions `p2i <-> i2p` needed.
>>
>> 2) Added a missed brace in the error message.
>>
>> Trivial change.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8364819: Addressed reviewer's comments
I still think these should be wrapped with `Atomic`-s, but I don't have energy to argue in favor of them anymore. So I would defer a second review to someone else.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26656#pullrequestreview-3097025636
More information about the hotspot-dev
mailing list