RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v3]
Quan Anh Mai
qamai at openjdk.org
Fri Aug 8 15:27:13 UTC 2025
On Fri, 8 Aug 2025 15:17:06 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:
>> I assume this means that other `.d` files might include a header multiple times, too. Is it reasonable to count only the number of files containing a header instead of number of appearances?
>
>> I assume this means that other .d files might include a header multiple times, too.
>
> From the following two numbers, I deduce `code/codeCache.hpp` is (transitively) included in 1230 files, with each inclusion coming from a unique `.d` file. Am I missing something?
>
>
> % grep "code/codeCache.hpp" build/clang/hotspot/variant-server/libjvm/objs/*.d | grep -v BUILD | sort | wc -l
> 1230
>
> % grep "code/codeCache.hpp" build/clang/hotspot/variant-server/libjvm/objs/*.d | grep -v BUILD | sort | uniq | wc -l
> 1230
>
>
> I haven't checked every single file, but I'd expect each include to appear at most once in each `.d` file.
Thanks for the clarification, I think that it is fine, then, although a comment explaining in the code would be great.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26681#discussion_r2263272948
More information about the hotspot-dev
mailing list