RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v8]

Francesco Andreuzzi duke at openjdk.org
Fri Aug 8 15:35:17 UTC 2025


On Fri, 8 Aug 2025 15:28:41 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Francesco Andreuzzi has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - two times might be too much
>>  - ops
>
> src/utils/PrecompiledHeaders/PrecompiledHeaders.java line 85:
> 
>> 83:                         try {
>> 84:                             // The first line contains the object name
>> 85:                             return Files.lines(file).skip(1);
> 
> Or maybe `return Files.lines(file).skip(1).distinct()`?

`distinct()` has some overhead, do we need it? Do we expect duplicate headers in a file?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26681#discussion_r2263292750


More information about the hotspot-dev mailing list