RFR: 8364819: Post-integration cleanups for JDK-8359820 [v7]
Aleksey Shipilev
shade at openjdk.org
Tue Aug 12 10:02:16 UTC 2025
On Tue, 12 Aug 2025 09:29:06 GMT, Anton Artemov <duke at openjdk.org> wrote:
>> Hi, please consider the following changes:
>>
>> This is a cleanup after https://github.com/openjdk/jdk/pull/26309
>>
>> 1) `_handshake_timed_out_thread `and `_safepoint_timed_out_thread` are now `Thread*` and not `intptr_t`, no conversions `p2i <-> i2p` needed.
>>
>> 2) Added a missed brace in the error message.
>>
>> 3) Updates are done with `Atomic::replace_if_null()` to address possible multiple updates and visibility among all threads.
>>
>> Trivial change.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8364819: Fixed whitespace error.
OK, this looks more straight-forward. I would still prefer to see `Atomic::load` (can be without acquire) for loads on reader side to match the `Atomic` RMW on writer side. This would give us at least coherency for the load.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26656#pullrequestreview-3109698132
More information about the hotspot-dev
mailing list