RFR: 8328306: AArch64: MacOS lazy JIT "write xor execute" switching [v2]
Andrew Dinn
adinn at openjdk.org
Tue Aug 12 10:30:16 UTC 2025
On Tue, 12 Aug 2025 10:07:42 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> src/hotspot/share/runtime/threadWXSetters.inline.hpp line 38:
>>
>>> 36:
>>> 37: class ThreadWXEnable {
>>> 38: Thread *_thread;
>>
>> * needs to be attached to type not field here and below.
>
>> * needs to be attached to type not field here and below.
>
> I'm afraid this is against the guidelines. At least that is what I've been told, but I can't find it in the guidelines, so maybe that isn't true.
No, it's not explicitly stated in the [guidelines](https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md) but it is adopted 'almost everywhere' in the code base. Likewise with reference parameter declarations the '&' attaches to the type.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26562#discussion_r2269408869
More information about the hotspot-dev
mailing list