RFR: 8317269: Store old classes in linked state in AOT cache
Ioi Lam
iklam at openjdk.org
Wed Aug 13 00:04:07 UTC 2025
During the assembly phase of the AOT cache, we link and verify all classes that were loaded during the training run. When verifying a class like this:
class X {
A getA() { return new B(); } // Verifier requires B to be a subtype of A.
}
We remember `A` and `B` as the "verification dependencies" of `X`. A class will be excluded from the AOT cache if any of its verification dependencies are excluded. For example, `X` will be excluded if
- `A` fails verification
- `B` is a signed class, which is always excluded from the AOT cache
Conversely, if both `A` and `B` are included in the AOT cache, in the production run, they will be unconditionally loaded during VM bootstrap. Therefore, we can guarantee that the verification result computed for `X` will remain valid during the production run.
Notes for reviewers:
- The checks for verification dependencies are done inside `SystemDictionaryShared::check_exclusion_for_self_and_dependencies()`. These checks are done for both old and new classes. Since the dependencies can form a cyclic graph, the checks cannot be implemented with a simple recursion. See "Algorithm notes" in this function for details.
- The verification dependencies for "new" classes are already stored in `DumpTimeClassInfo::_verifier_constraints`.
- This PR adds code to record the verification dependencies for "old" classes into `DumpTimeClassInfo::_old_verifier_dependencies`, by intercepting `JVM_FindClassFromCaller()`.
- This new functionality (store old classes in linked state) is available only when using the AOT cache. For simplicity, this functionality is not available with the old CDS workflows. See comments in `CDSConfig::is_preserving_verification_dependencies()`.
-------------
Commit messages:
- 8317269: Store old classes in linked state in AOT cache
Changes: https://git.openjdk.org/jdk/pull/26754/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26754&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8317269
Stats: 1237 lines in 29 files changed: 1154 ins; 22 del; 61 mod
Patch: https://git.openjdk.org/jdk/pull/26754.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26754/head:pull/26754
PR: https://git.openjdk.org/jdk/pull/26754
More information about the hotspot-dev
mailing list