RFR: 8328306: AArch64: MacOS lazy JIT "write xor execute" switching [v2]
Andrew Haley
aph at openjdk.org
Thu Aug 14 08:22:56 UTC 2025
On Wed, 13 Aug 2025 22:17:48 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp
>>
>> Co-authored-by: Bernhard Urban-Forster <lewurm at gmail.com>
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 249:
>
>> 247: // If we got a SIGBUS because we tried to write into the code
>> 248: // cache, try enabling WXWrite mode.
>> 249: if (sig == SIGBUS && pc != info->si_addr && CodeCache::contains(info->si_addr)) {
>
> Suggestion:
>
> if (sig == SIGBUS && pc != info->si_addr && CodeCache::contains(info->si_addr) && !CodeCache::contains(pc)) {
>
> I think we want to make sure the code doing the write is outside the codecache.
Ah yes, good point.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26562#discussion_r2275848624
More information about the hotspot-dev
mailing list