RFR: 8365047: Remove exception handler stub code in C2 [v2]

Ruben duke at openjdk.org
Thu Aug 14 08:56:20 UTC 2025


On Mon, 11 Aug 2025 08:17:35 GMT, Ruben <duke at openjdk.org> wrote:

>> src/hotspot/cpu/s390/s390.ad line 1652:
>> 
>>> 1650:  public:
>>> 1651: 
>>> 1652:   static int emit_exception_handler(C2_MacroAssembler *masm);
>> 
>> Is this declaration still needed?
>
> No, it should be removed as well - I will update the patch.

Removed.

>> src/hotspot/share/code/nmethod.cpp line 1486:
>> 
>>> 1484:       }
>>> 1485: 
>>> 1486:       assert(offsets->value(CodeOffsets::Deopt     ) != -1, "must be set");
>> 
>> It might be good to leave this line where it was at the beginning of the block, just to avoid one more diff.
>
> Sure, I will update this.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26678#discussion_r2275957410
PR Review Comment: https://git.openjdk.org/jdk/pull/26678#discussion_r2275957769


More information about the hotspot-dev mailing list