RFR: 8328306: AArch64: MacOS lazy JIT "write xor execute" switching [v2]
Dean Long
dlong at openjdk.org
Sat Aug 16 00:10:12 UTC 2025
On Tue, 12 Aug 2025 09:50:47 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp
>>
>> Co-authored-by: Bernhard Urban-Forster <lewurm at gmail.com>
>
> src/hotspot/share/runtime/threads.cpp line 599:
>
>> 597: }
>> 598:
>> 599: MACOS_AARCH64_ONLY(os::current_thread_enable_wx(WXWrite));
>
> I think for clarity this call should really precede the call to init_globals() a few lines up.
>
> That function calls, amongst other things, codeCache_init() then VM_Version_init() and the latter may need to write into the code cache for some architectures.
There is already a call at line 465, so this one is redundant.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26562#discussion_r2280046606
More information about the hotspot-dev
mailing list