RFR: 8360389: Support printing from C2 compiled code [v2]

[Benoît Maillard]

On Mon, 18 Aug 2025 09:03:29 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/hotspot/share/opto/compile.cpp
>>    
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>>  - Update src/hotspot/share/runtime/sharedRuntime.cpp
>>    
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>
> src/hotspot/share/opto/compile.cpp line 5483:
> 
>> 5481: }
>> 5482: 
>> 5483: #endif
> 
> Suggestion:
> 
> #endif // !PRODUCT
> 
> Nit: This makes it a bit easier to follow the ifdefs.

Good catch

> src/hotspot/share/runtime/sharedRuntime.cpp line 305:
> 
>> 303: void SharedRuntime::debug_print_value(oopDesc* x) {
>> 304:   x->print();
>> 305: }
> 
> Can you elaborate why you need an empty print?

This is not an empty print, this is `oopDesc::print` 😉

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26475#discussion_r2284300915
PR Review Comment: https://git.openjdk.org/jdk/pull/26475#discussion_r2284299340