RFR: 8364819: Post-integration cleanups for JDK-8359820 [v8]

[Anton Artemov]

On Sun, 17 Aug 2025 21:43:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8364819: Added atomic loads to getters
>
> src/hotspot/share/utilities/vmError.cpp line 1345:
> 
>> 1343:   // updates except the 1st one. Those can hypothetically happen
>> 1344:   // if more than one thread times out.
>> 1345:   // The default memory ordering guarantees visibility to other threads.
> 
> The use of `replace_if_null` is a good alternative here. The comment is a bit wordy. I would suggest a simpler:
> 
> // Only preserve the first thread to time-out this way. The atomic operation ensures
> // visibility to the target thread.
> 
> and of course the same comment needs to be in `set_safepoint_timed_out_thread` (or else use a comment block before the two functions to describe both their operations at once).

Thanks, I changed the comments as suggested in both methods.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26656#discussion_r2284381890