RFR: 8365799: AArch64: Remove trailing DMB from cmpxchgptr for LSE [v2]

Samuel Chee duke at openjdk.org
Tue Aug 19 15:58:52 UTC 2025


> According to the Java SE 24 API, CompareAndExchange has the memory semantics as given by VarHandle.compareAndExchange, which has the following effects [1]:
> 
>> Atomically sets the value of a variable to the newValue with the
>> memory semantics of setVolatile if the variable's current value,
>> referred to as the witness value, == the expectedValue, as accessed
>> with the memory semantics of getVolatile.
> 
> Thus, the store-release due to setVolatile only occurs if the compare is successful. Since CASAL already satisfies these requirements, the DMB does not need to occur to ensure memory ordering in case the compare fails and a store-release does not happen.
> 
> Therefore, we can remove the DMB from cmpxchgptr when LSE is enabled. We also rename it to cmpxchgptr_barrier to indicate that this method provides trailing barrier semantics (via either LSE CASAL or a DMB).
> 
> The unused cmpxchgw is removed.
> 
> [1] https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/lang/invoke/VarHandle.html#compareAndExchange(java.lang.Object...)

Samuel Chee has updated the pull request incrementally with one additional commit since the last revision:

  Merge master fix
  
  Change-Id: I74d44f711de208395bce47595fecd801564bcb54

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26845/files
  - new: https://git.openjdk.org/jdk/pull/26845/files/4a95340c..e6e46d16

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26845&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26845&range=00-01

  Stats: 68 lines in 1 file changed: 0 ins; 65 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/26845.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26845/head:pull/26845

PR: https://git.openjdk.org/jdk/pull/26845


More information about the hotspot-dev mailing list