RFR: 8359222: [asan] jvmti/vthread/ToggleNotifyJvmtiTest/ToggleNotifyJvmtiTest triggers stack-buffer-overflow error [v4]

Patricio Chilano Mateo pchilanomate at openjdk.org
Tue Aug 19 20:42:23 UTC 2025


On Tue, 19 Aug 2025 19:03:58 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use existing badAddressVal
>
> src/hotspot/cpu/x86/continuationFreezeThaw_x86.inline.hpp line 34:
> 
>> 32: 
>> 33: // fp value used for frozen stub/native frame
>> 34: static intptr_t* const UNUSED_FP = reinterpret_cast<intptr_t*>(UCONST64(0xC0C0C0C0DEADBAAD));
> 
> In globalDefinitions.hpp there's a block of special constants for debugging.  Can you add this constant to that with a generic name so that it might be reusable for other stack related addresses.
> 
> Or just use badAddressVal, which is -2. I don't think it's going to crash a lot so you'd need something very recognizable.  Just something that would crash.

Right, that’s better. Changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26660#discussion_r2286279144


More information about the hotspot-dev mailing list