RFR: 8317269: Store old classes in linked state in AOT cache [v2]

[Ioi Lam]

On Tue, 19 Aug 2025 21:02:07 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed bugs found in JCK testing
>
> src/hotspot/share/cds/dumpTimeClassInfo.cpp line 90:
> 
>> 88:     _old_verifier_dependencies = new (mtClass) GrowableArray<Symbol*>(4, mtClass);
>> 89:   }
>> 90:   _old_verifier_dependencies->append(name);
> 
> I wonder why there's append and push that do the same thing in GrowableArray.  I'm used to seeing push().

I am not sure why there are two versions.  They seem to be used at similar frequency (about 300 calls each).

> src/hotspot/share/cds/metaspaceShared.cpp line 636:
> 
>> 634: 
>> 635: void VM_PopulateDumpSharedSpace::doit() {
>> 636:   CDSConfig::set_is_at_cds_safepoint(true);
> 
> Can you just use SafepointSynchronize::is_at_safepoint()?  Why new flag?

We need to know if are are at the CDS safepoint, not any safepoint.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2286614502
PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2286615456