RFR: 8365192: post_meth_exit should be in vm state when calling get_jvmti_thread_state [v5]
David Holmes
dholmes at openjdk.org
Wed Aug 20 07:36:43 UTC 2025
On Wed, 20 Aug 2025 06:42:38 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> It is normal/common to have a directory Foo that contains both Foo.java and libFoo.cpp
>
> The test name would be
> test/hotspot/jtreg/serviceability/jvmti/events/MethodExit/ExceptionOccurred/ExceptionOccurred.java
> I don't like this duplication.
It is common to use a `Test` prefix on the actual file so we have directory `foo`, containing `TestFoo.java` and `libFoo.cpp` (or 'libTestFoo.cpp`). The point is that all the source files for one test reside in the same directory unless a different structure is needed for some reason. Placing the native code in its own subdirectory looks very odd to me. But of course there is no general consistency here and it depends on who wrote the test cases and when.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26713#discussion_r2287263124
More information about the hotspot-dev
mailing list