RFR: 8365192: post_meth_exit should be in vm state when calling get_jvmti_thread_state [v10]
David Holmes
dholmes at openjdk.org
Wed Aug 20 07:50:40 UTC 2025
On Wed, 20 Aug 2025 06:46:03 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> The method
>> get_jvmti_thread_state()
>> should be called only while thread is in vm state.
>>
>> The post_method_exit is doing some preparation before switching to vm state. This cause issues if thread is needed to initialize jvmti thread state.
>>
>> The fix was found using jvmti stress agent and thus no additional regression test is required.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>
> Update src/hotspot/share/prims/jvmtiExport.cpp
>
> Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
test/hotspot/jtreg/serviceability/jvmti/events/MethodExit/ExceptionOccurred/libExceptionOccurred.cpp line 35:
> 33: // has been popped by exception and call 'upCall' mthod using JNI.
> 34: // 2) for upCall method it verifies that event has correct
> 35: // return value and was not popped by execption.
Suggestion:
// return value and was not popped by exception.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26713#discussion_r2287292340
More information about the hotspot-dev
mailing list