RFR: 8365407: Race condition in MethodTrainingData::verify() [v4]

[David Holmes]

On Thu, 21 Aug 2025 03:00:11 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

>> This change fixes multiple issue with training data verification. While the current state of things in the mainline will not cause  any issues (because of the absence of the call to `TD::verify()` during the shutdown) it does problems in the leyden repo. This change strengthens verification in the mainline (by adding the shutdown verify call), and fixes the problems that prevent  it from working reliably.
>
> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More cleanup

src/hotspot/share/compiler/compilationPolicy.cpp line 173:

> 171: }
> 172: 
> 173: void CompilationPolicy::replay_training_at_init(InstanceKlass* klass, JavaThread* THREAD) {

Please rename `THREAD` to `current`. `THREAD` is still inherently part of the `TRAPS` mechanism.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26866#discussion_r2289757585