RFR: 8347707: Standardise the use of os::snprintf and os::snprintf_checked [v2]

[David Holmes]

On Wed, 20 Aug 2025 22:21:45 GMT, Dean Long <dlong at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reviewer feedback
>
> src/hotspot/os/aix/porting_aix.cpp line 939:
> 
>> 937:   // retrieve the path to the currently running executable binary
>> 938:   // to open it
>> 939:   os::snprintf_checked(buffer, 100, "/proc/%ld/object/a.out", (long)getpid());
> 
> Suggestion:
> 
>   os::snprintf_checked(buffer, sizeof(buffer), "/proc/%ld/object/a.out", (long)getpid());

It doesn't really matter as we only need at most 30 bytes.

> src/hotspot/os/aix/porting_aix.cpp line 1157:
> 
>> 1155:       }
>> 1156:       if (ebuf != nullptr && ebuflen > 0) {
>> 1157:         os::snprintf_checked(ebuf, ebuflen - 1, "%s", error_report);
> 
> Suggestion:
> 
>         (void) os::snprintf(ebuf, ebuflen - 1, "%s", error_report);

See previous replies.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26849#discussion_r2290002985
PR Review Comment: https://git.openjdk.org/jdk/pull/26849#discussion_r2290003771