RFR: 8357086: os::xxx functions returning memory size should return size_t [v31]

[Anton Artemov]

On Thu, 21 Aug 2025 09:08:41 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8357086: Addressed reviewers' comments
>
> src/hotspot/os/windows/os_windows.cpp line 882:
> 
>> 880:     return true;
>> 881:   } else {
>> 882:     assert(false, "GlobalMemoryStatusEx failed in win32::total_swap_space(): %lu", ::GetLastError());
> 
> Suggestion:
> 
>     assert(false, "GlobalMemoryStatusEx failed in os::total_swap_space(): %lu", ::GetLastError());

Thanks for spotting. Addressed in all affected lines.

> src/hotspot/os/windows/os_windows.cpp line 895:
> 
>> 893:     return true;
>> 894:   } else {
>> 895:     assert(false, "GlobalMemoryStatusEx failed in win32::free_swap_space(): %lu", ::GetLastError());
> 
> Suggestion:
> 
>     assert(false, "GlobalMemoryStatusEx failed in os::free_swap_space(): %lu", ::GetLastError());

Thanks for spotting. Addressed in all affected lines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2290436377
PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2290436617