RFR: 8357086: os::xxx functions returning memory size should return size_t [v33]

[Coleen Phillimore]

On Thu, 21 Aug 2025 12:17:02 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Anton Artemov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 35 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into JDK-8357086_size_t_memfuncs
>>  - 8357086: Addressed reviewer's comments
>>  - 8357086: Addressed reviewers' comments
>>  - Merge remote-tracking branch 'origin/master' into JDK-8357086_size_t_memfuncs
>>  - 8357086: Addressed reviewer's comments
>>  - 8357086: Addressed reviewer's comments
>>  - 8357086: Fixed whitespace error
>>  - 8357086: Addressed reviewer's comments
>>  - 8357086: Addressed reviewer's comments
>>  - 8357086: Addressed reviewer's comments
>>  - ... and 25 more: https://git.openjdk.org/jdk/compare/02fe095d...99599ae3
>
> src/hotspot/os/windows/os_windows.cpp line 869:
> 
>> 867:     return true;
>> 868:   } else {
>> 869:     assert(false, "GlobalMemoryStatusEx failed in os::available_memory(): %lu", ::GetLastError());
> 
> I didn't request this to be changed and it was changed to the wrong function name.
> 
> Suggestion:
> 
>     assert(false, "GlobalMemoryStatusEx failed in os::win32::available_memory(): %lu", ::GetLastError());
> 
> 
> Tip: you can accept suggestions in the GitHub UI to get exactly what the reviewer requested (if you are brave enough to trust the reviewer :D )

Yes, this is really convenient but you have to remember to pull back to your local repo if you want to make additional changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2290988873