RFR: 8365407: Race condition in MethodTrainingData::verify() [v4]

[Igor Veresov]

On Thu, 21 Aug 2025 16:58:08 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More cleanup
>
> src/hotspot/share/oops/trainingData.cpp line 86:
> 
>> 84: 
>> 85: void TrainingData::verify() {
>> 86:   if (TrainingData::have_data() && !TrainingData::assembling_data()) {
> 
> Why assembly phase excluded?

We don't hookup the dep tracking machinery for some of the classes just yet. So the dep counter verification can fail.

> src/hotspot/share/oops/trainingData.cpp line 105:
> 
>> 103:     });
>> 104:   }
>> 105:   if (TrainingData::need_data()) {
> 
> I assume this is "training" run. Right?

Yes

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26866#discussion_r2291704095
PR Review Comment: https://git.openjdk.org/jdk/pull/26866#discussion_r2291704534