RFR: 8365206: RISC-V: compiler/c2/irTests/TestFloat16ScalarOperations.java is failing on riscv64 [v5]
Dingli Zhang
dzhang at openjdk.org
Fri Aug 22 14:53:57 UTC 2025
On Fri, 22 Aug 2025 12:22:31 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Hi,
>> Can you help to review this patch?
>>
>> Currently implementation of conversion from float to float16 only preserve some significant bits of a NaN, which is not right in some cases.
>> As this (NaN conversion from float to float16) is already in the slow path, so I'll just fix it by preserving all significant bits in the same way as j.l.Float.floatToFloat16.
>> As current tests does not catch the issue, except of TestFloat16ScalarOperations.java, so add another test.
>>
>> There is also the similar issue in vector version of conversion from float to float16, I'll address it in another pr [JDK-8365772](https://bugs.openjdk.org/browse/JDK-8365772)
>>
>> Thanks!
>
> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
>
> - indent
> - comments & readability
LGTM, thanks!
-------------
Marked as reviewed by dzhang (Author).
PR Review: https://git.openjdk.org/jdk/pull/26838#pullrequestreview-3144815276
More information about the hotspot-dev
mailing list