RFR: 8365407: Race condition in MethodTrainingData::verify() [v6]

Vladimir Kozlov kvn at openjdk.org
Fri Aug 22 16:38:55 UTC 2025


On Fri, 22 Aug 2025 03:21:36 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

>> This change fixes multiple issue with training data verification. While the current state of things in the mainline will not cause  any issues (because of the absence of the call to `TD::verify()` during the shutdown) it does problems in the leyden repo. This change strengthens verification in the mainline (by adding the shutdown verify call), and fixes the problems that prevent  it from working reliably.
>
> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More renames

src/hotspot/share/compiler/compilationPolicy.cpp line 192:

> 190: 
> 191: void CompilationPolicy::replay_training_at_init_loop(JavaThread* current) {
> 192:   while (!CompileBroker::is_compilation_disabled_forever() || AOTVerifyTrainingData) {

Will it loop forever with `+ AOTVerifyTrainingData` ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26866#discussion_r2294183959


More information about the hotspot-dev mailing list