RFR: 8314488: Compiling the JDK with C++17 [v3]
Kim Barrett
kbarrett at openjdk.org
Mon Aug 25 17:57:40 UTC 2025
On Mon, 25 Aug 2025 11:06:10 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>>
>> dholmes tweaks
>
> doc/hotspot-style.md line 1509:
>
>> 1507: with files, and already has adequate mechanisms for its needs. Rewriting in
>> 1508: terms of this new library would not be a good use of resources. Having a mix
>> 1509: of the existing usage and uses of this new library would just be confusing.
>
> I'm not sure the style guide should be opinionated about we choose to use our resources. Could this be slightly tweaked to not say that?
Rewriting as "would not be a good use of resources" => "doesn't provide any obviously
significant benefits".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26884#discussion_r2298742971
More information about the hotspot-dev
mailing list