RFR: 8314488: Compiling the JDK with C++17 [v3]

Kim Barrett kbarrett at openjdk.org
Mon Aug 25 21:01:34 UTC 2025


On Mon, 25 Aug 2025 11:19:22 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   dholmes tweaks
>
> doc/hotspot-style.md line 1567:
> 
>> 1565: in HotSpot code because of the
>> 1566: [no implicit boolean](#avoid-implicit-conversions-to-bool)
>> 1567: guideline.)
> 
>> (Note that conversion to `bool` isn't needed ...
> 
> Pre-existing: This section sounds weird to me. It more or less says "it isn't needed because we forbid it". I think people can still feel the need to use it. Maybe this could be changed to say something like:
> 
>> (Note that conversion to `bool` isn't permitted
> in HotSpot code because of the
> [no implicit boolean](#avoid-implicit-conversions-to-bool)
> guideline.)
> 
> or something like that. (This doesn't have to be fixed in this PR if you disagree)

This is about the conversion operators. I'm making that more explicit.
"Conversion to `bool` operators aren't needed because ..."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26884#discussion_r2299125800


More information about the hotspot-dev mailing list