RFR: 8366037: Remove oopDesc::mark_addr() [v2]
Thomas Schatzl
tschatzl at openjdk.org
Tue Aug 26 07:25:34 UTC 2025
On Tue, 26 Aug 2025 03:51:34 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Please review this change that removes the function oopDesc::mark_addr().
>> It's kind of a suspicious function, since it is casting away the volatile for
>> a location that has concurrent reads and writes. But there isn't any code that
>> examines the value at the obtained address. Instead, it's just used as the
>> base address for a few prefetches. We change those places accordingly, and
>> remove the now unused mark_addr function.
>>
>> Testing: mach5 tier1
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>
> base_addr
Marked as reviewed by tschatzl (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/26914#pullrequestreview-3154292570
More information about the hotspot-dev
mailing list