RFR: 8357086: os::xxx functions returning memory size should return size_t [v34]

[Anton Artemov]

On Tue, 26 Aug 2025 05:24:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8357086: Fixed method name in assert in os_windows.cpp
>>   
>>   Co-authored-by: Stefan Karlsson <stefan.karlsson at oracle.com>
>
> src/hotspot/share/utilities/globalDefinitions.hpp line 60:
> 
>> 58: 
>> 59: // Dummy placeholder for use of [[nodiscard]]
>> 60: #define ATTRIBUTE_NODISCARD
> 
> I think you can just use `[[nodiscard]]` directly now. We are going to allow it and the guide is just going through the official update process.

Removed as suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2300240779