RFR: 8365163: [ubsan] left-shift issue in globalDefinitions.hpp [v4]
Afshin Zafari
azafari at openjdk.org
Tue Aug 26 12:44:33 UTC 2025
> There was a left-shift of negative value UB in `set_high` function where the high value sign bit is on and is left-shifted 32 bits to put it in high word of the destination address.
> To address it, first the left 32 bits of the provided `high` arg is cleared and then left-shifted 32 bits.
>
> Tests:
> mach5 tiers 1-5 {macosx-aarch64, linux-x64, windows-x64} x {debug, product}
Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
explicit casting of 'long long' vs 'long' for windows compatibility.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26809/files
- new: https://git.openjdk.org/jdk/pull/26809/files/b525ba07..6b02c0e9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26809&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26809&range=02-03
Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/26809.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26809/head:pull/26809
PR: https://git.openjdk.org/jdk/pull/26809
More information about the hotspot-dev
mailing list