RFR: 8365885: Clean up constant pool reflection native code

Chen Liang liach at openjdk.org
Tue Aug 26 13:04:38 UTC 2025


On Wed, 20 Aug 2025 21:29:29 GMT, Chen Liang <liach at openjdk.org> wrote:

> When I was trying to reuse this constant pool reflection for assembly phase indy argument validation, I noted the JNI code has a lot of confusing arguments. In particular, the JVM_ConstantPoolGetSize is wrong because of argument confusion. We should remove the unused arguments to reduce confusion.

I think the old code consistently dropped the oop and used the instance despite what the jvm.h names indicate - if you call reflect_ConstantPool's function on the constantPoolOop (i.e. java.lang.Class for an IK) you get a crash.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26870#issuecomment-3224087039


More information about the hotspot-dev mailing list