RFR: 8365661: oops/resolvedMethodEntry.hpp could use default copy constructor [v3]

[Ioi Lam]

On Mon, 25 Aug 2025 09:02:49 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

>> We may replace the non-default copy constructor and assignment with the default ones. It seems that all we have to do is a member-wise shallow copy. This would also make the class `TriviallyCopiable`.
>> 
>> This change fixes a build failure I'm getting with clang20:
>> 
>> /jdk/src/hotspot/share/oops/resolvedMethodEntry.cpp:43:12: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'ResolvedMethodEntry' [-Werror,-Wnontrivial-memcall]
>>    43 |     memset(this, 0, sizeof(*this));
>>       |            ^
>> /jdk/src/hotspot/share/oops/resolvedMethodEntry.cpp:43:12: note: explicitly cast the pointer to silence this warning
>>    43 |     memset(this, 0, sizeof(*this));
>>       |            ^
>>       |            (void*)
>> /jdk/src/hotspot/share/oops/resolvedMethodEntry.cpp:48:12: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'ResolvedMethodEntry' [-Werror,-Wnontrivial-memcall]
>>    48 |     memset(this, 0, sizeof(*this));
>>       |            ^
>> /jdk/src/hotspot/share/oops/resolvedMethodEntry.cpp:48:12: note: explicitly cast the pointer to silence this warning
>>    48 |     memset(this, 0, sizeof(*this));
>>       |            ^
>>       |            (void*)
>> 2 errors generated.
>> 
>> 
>> Testing:
>> - [x] tier1 fast-debug
>> - [x] tier2 fast-debug
>
> Francesco Andreuzzi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into resolved-default-cctor
>  - Merge branch 'master' into resolved-default-cctor
>  - use copy ctor

I created a PR to add comments about the need for copy_from(), etc
https://github.com/openjdk/jdk/pull/26946

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26818#issuecomment-3225011217