RFR: 8365163: [ubsan] left-shift issue in globalDefinitions.hpp [v5]

Afshin Zafari azafari at openjdk.org
Wed Aug 27 08:24:59 UTC 2025


On Wed, 27 Aug 2025 00:11:30 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   CONST64 vs explicit casting.
>
> test/hotspot/gtest/utilities/test_globalDefinitions.cpp line 301:
> 
>> 299: TEST(globalDefinitions, jlong_from) {
>> 300:   jlong val = jlong_from(0xFF, 0);
>> 301:   EXPECT_EQ(val, 0x00000000FF00000000);
> 
> Should be using `CONST64` here and elsewhere.

Done. 
All windows tests had been passed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26809#discussion_r2303236799


More information about the hotspot-dev mailing list