RFR: 8365501: Remove speical AdapterHandlerEntry for abstract methods [v2]
Vladimir Kozlov
kvn at openjdk.org
Wed Aug 27 17:54:47 UTC 2025
On Wed, 27 Aug 2025 13:47:05 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:
>> This PR removes the need for having AdapterHandlerEntry for abstract methods. The check for abstract method is now done in the accessor functions in Method such as Method::get_i2c_entry().
>> Motivation for this change is described in the JBS issue.
>
> Ashutosh Mehra has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into remove-abstract_method_handler
> - 8365501: Remove speical AdapterHandlerEntry for abstract methods
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
src/hotspot/share/oops/method.cpp line 1292:
> 1290: } else if (is_abstract()) {
> 1291: h_method->_from_compiled_entry = SharedRuntime::get_handle_wrong_method_abstract_stub();
> 1292: }
Can you swap conditions? Check is_abstract() first and then (_adapter == nullptr).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26764#discussion_r2304876519
More information about the hotspot-dev
mailing list