RFR: 8246037: Shenandoah: update man pages to mention -XX:+UseShenandoahGC [v3]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Thu Aug 28 00:03:42 UTC 2025
On Wed, 27 Aug 2025 23:20:33 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> Rui Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update for comments
>
> src/java.base/share/man/java.md line 2915:
>
>> 2913: `adaptive`
>> 2914: : To maintain the given amount of free heap at all times, even during
>> 2915: the GC cycle.
>
> May be this part (and in `shenandoah_globals.hpp`) could be changed so as not to repeat the description of `adaptive`, by stating that the default setting is adaptive, but replacing the current description of `adaptive` at line 2914 with the text earlier at line 2909-2911.
@rgithubli correctly pointed out that the description at lines 2909-2911 describes the role of the option, not a description of the `adaptive` heuristic. My comment further above is withdrawn.
Please go ahead with what you had (modulo suggestions from other reviewers). Sorry for my confusion!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26907#discussion_r2305634536
More information about the hotspot-dev
mailing list