RFR: 8366331: Sort share/prims includes [v2]
Aleksey Shipilev
shade at openjdk.org
Thu Aug 28 09:38:43 UTC 2025
On Thu, 28 Aug 2025 09:35:24 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:
>> This PR sorts the includes in `hotspot/share/prims` using `SortIncludes.java`, and removes some unnecessary ones. I'm also adding the directory to `TestIncludesAreSorted`.
>>
>> Passes `tier1`.
>
> Francesco Andreuzzi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>
> - Merge branch 'master' into JDK-8366331
> - sort and delete
Looks fine with minor nit.
src/hotspot/share/prims/foreignGlobals.cpp line 25:
> 23:
> 24: #include "classfile/javaClasses.hpp"
> 25: #include "foreignGlobals.hpp"
This does not look right, even in the original code. Isn't it the same as `prims/foreignGlobals.hpp`, which is subsumed by the existing `prims/foreignGlobals.inline.hpp`?
-------------
PR Review: https://git.openjdk.org/jdk/pull/26980#pullrequestreview-3164054837
PR Review Comment: https://git.openjdk.org/jdk/pull/26980#discussion_r2306829785
More information about the hotspot-dev
mailing list