RFR: 8366238: Improve RBTree API with stricter comparator semantics and pluggable validation/printing hooks. [v2]

Casper Norrbin cnorrbin at openjdk.org
Thu Aug 28 09:58:44 UTC 2025


On Thu, 28 Aug 2025 09:40:48 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   renamed less to less_than
>
> src/hotspot/share/gc/z/zMappedCache.cpp line 121:
> 
>> 119: }
>> 120: 
>> 121: bool ZMappedCache::EntryCompare::less(const IntrusiveRBNode* a, const IntrusiveRBNode* b) {
> 
> I feel `less_than` sounds more natural as a method name; it also avoids "conflicting" with `RBTreeOrdering::less`.

Sounds like a good suggestion, done now in 9dd20db

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26981#discussion_r2306891336


More information about the hotspot-dev mailing list