RFR: 8317269: Store old classes in linked state in AOT cache [v5]

[Coleen Phillimore]

On Fri, 29 Aug 2025 20:52:08 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8317269-store-old-classes-in-linked-state-in-aot-cache
>>  - @matias9927 comments: fixed typos
>>  - clean up; removed unrelated change
>>  - Cleaned up iterate_verification_dependency_names so a return value of false from <func> means early termination (similar to HashTable::iterate())
>>  - Merge branch 'master' into 8317269-store-old-classes-in-linked-state-in-aot-cache
>>  - @coleenp comments
>>  - More bug fixes from JCK testing
>>  - Fixed bugs found in JCK testing
>>  - 8317269: Store old classes in linked state in AOT cache
>
> src/hotspot/share/classfile/systemDictionaryShared.cpp line 1036:
> 
>> 1034:   DumpTimeClassInfo* info = get_info(ik);
>> 1035:   Handle loader(current, ik->class_loader());
>> 1036:   Klass* k = SystemDictionary::find_instance_or_array_klass(current, name, loader);
> 
> The caller just did this, didn't it?  So, you should just be able to pass in from_class (unless it's null).

I would kind of prefer old_verifier_dependency rather than old_verification - the latter seems to say that we had some verification that is no longer valid.  old_verifier makes it clearer it's for old classfiles and the old verifier.  Also 'verification' is used for the regular verifier so it's less of a same name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2311263886