RFR: 8317269: Store old classes in linked state in AOT cache [v4]

Coleen Phillimore coleenp at openjdk.org
Fri Aug 29 21:54:54 UTC 2025


On Fri, 29 Aug 2025 20:25:34 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8317269-store-old-classes-in-linked-state-in-aot-cache
>>  - @coleenp comments
>>  - More bug fixes from JCK testing
>>  - Fixed bugs found in JCK testing
>>  - 8317269: Store old classes in linked state in AOT cache
>
> src/hotspot/share/prims/jvm.cpp line 854:
> 
>> 852: 
>> 853: #if INCLUDE_CDS
>> 854:   if (CDSConfig::is_preserving_verification_dependencies() && from_class->is_instance_klass()) {
> 
> It looks like from_class can be null so you have to check for null here.
> Which doesn't make sense because the logging doesn't have null checks.

This looks like something that should be cleaned up apart from this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2311378906


More information about the hotspot-dev mailing list