RFR: 8277444: Data race between JvmtiClassFileReconstituter::copy_bytecodes and class linking [v3]
Evgeny Astigeevich
eastigeevich at openjdk.org
Fri Aug 29 22:58:43 UTC 2025
On Fri, 29 Aug 2025 14:07:51 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Evgeny Astigeevich has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Symplify comments; Get JavaThread::current in variable
>
> Okay I ran the test case in the issue and I see why it wouldn't be reliable. I verified it with the new more minimalistic patch here: https://github.com/openjdk/jdk/pull/26971
@coleenp,
I have pulled your changes.
I added a `guarantee` check to `copy_bytecodes`. IMO it's better to be overcautious to prevent incorrect uses of `copy_bytes`. Because of it I had to add `link_class` to `GetBytecodes`.
I don't use the macros because they rely on `THREAD`. It is a variable in your patch but it is usually used as a macro.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26863#issuecomment-3238571537
More information about the hotspot-dev
mailing list