RFR: 8366474: Rename MetaspaceObj::is_shared() to MetaspaceObj::in_aot_cache()

[Vladimir Kozlov]

On Sat, 30 Aug 2025 14:01:00 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Rename `is_shared()` in `Metaspace` (and various other classes) to `in_aot_cache()` to reflect its true meaning:
>> - tests if an object is inside the AOT cache's metaspace region.
>> 
>> Also various forms of  "shared metaspace" are updated to "aot metaspace"
>> 
>> Please start your review with allocations.hpp
>
> src/hotspot/share/include/cds.h line 38:
> 
>> 36: // Also, this is a C header file. Do not use C++ here.
>> 37: 
>> 38: #define NUM_CDS_REGIONS 5 // this must be the same as AOTMetaspace::n_regions
> 
> This file changes seems belong to your other RFE JDK-8366475.

But I am fine to have it here - it is only in comments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27016#discussion_r2311954625