RFR: 8366475: Rename MetaspaceShared class to AOTMetaspace

Vladimir Kozlov kvn at openjdk.org
Sat Aug 30 14:17:45 UTC 2025


On Sat, 30 Aug 2025 02:21:32 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Rename this class to with a naming convention that's consistent with other new AOT classes such as AOTClassLinker.
> 
> All changes are mechanical text replacement. Headers are resorted alphabetically.

Good.

@stefank also asked about `INCLUDE_CDS` to replace it with `INCLUDE_AOT`. Should we do this?

src/hotspot/share/oops/symbol.cpp line 26:

> 24: 
> 25: #include "cds/archiveBuilder.hpp"
> 26: #include "cds/metaspaceShared.hpp"

Do you have usage in this file?

src/hotspot/share/oops/trainingData.cpp line 26:

> 24: 
> 25: #include "cds/cdsConfig.hpp"
> 26: #include "cds/metaspaceShared.hpp"

Usage?

src/hotspot/share/prims/whitebox.cpp line 2887:

> 2885:   {CC"incMetaspaceCapacityUntilGC", CC"(J)J",         (void*)&WB_IncMetaspaceCapacityUntilGC },
> 2886:   {CC"metaspaceCapacityUntilGC", CC"()J",             (void*)&WB_MetaspaceCapacityUntilGC },
> 2887:   {CC"metaspaceSharedRegionAlignment", CC"()J",       (void*)&WB_AOTMetaspaceRegionAlignment },

Should you rename `metaspaceSharedRegionAlignment` too?

-------------

PR Review: https://git.openjdk.org/jdk/pull/27017#pullrequestreview-3171056781
PR Comment: https://git.openjdk.org/jdk/pull/27017#issuecomment-3239296387
PR Review Comment: https://git.openjdk.org/jdk/pull/27017#discussion_r2311958757
PR Review Comment: https://git.openjdk.org/jdk/pull/27017#discussion_r2311958793
PR Review Comment: https://git.openjdk.org/jdk/pull/27017#discussion_r2311959087


More information about the hotspot-dev mailing list