RFR: 8372652: Re-enable LocalRandom clinit after monitor pinning improvements
Vishal Chand
duke at openjdk.org
Tue Dec 2 11:33:47 UTC 2025
On Mon, 1 Dec 2025 22:38:29 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>>> Unfortunately, there are might be failure of execution `vmTestbase/`with `JTREG_TEST_THREAD_FACTORY=Virtual`. So it enough ensure the your fix doesn't create new failures and timeouts
>>
>> I am trying to parse this :) So, if `make test TEST=vmTestbase/ JTREG=TEST_THREAD_FACTORY=Virtual` passes, we are good to go, correct?
>
>> > Unfortunately, there are might be failure of execution `vmTestbase/`with `JTREG_TEST_THREAD_FACTORY=Virtual`. So it enough ensure the your fix doesn't create new failures and timeouts
>>
>> I am trying to parse this :) So, if `make test TEST=vmTestbase/ JTREG=TEST_THREAD_FACTORY=Virtual` passes, we are good to go, correct?
>
> Sure.
> I meant that we don't run whole vmTestbase with TEST_THREAD_FACTORY=Virtual, so I am unsure if there are some failures exist now.
@lmesnik There are failures with `make test TEST=vmTestbase/ JTREG=TEST_THREAD_FACTORY=Virtual` even without the change. And it is worse as the tests are flaky, so it is hard to compare with and without the change.
Below are the test results `without` the change for 3 runs:
TEST TOTAL PASS FAIL ERROR SKIP
jtreg:test/hotspot/jtreg/vmTestbase 3056 2990 17 4 45
jtreg:test/hotspot/jtreg/vmTestbase 3059 2991 18 6 44
jtreg:test/hotspot/jtreg/vmTestbase 3062 2996 17 4 45
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28547#issuecomment-3601574459
More information about the hotspot-dev
mailing list