RFR: 8366671: Refactor Thread::SpinAcquire and Thread::SpinRelease [v12]
Coleen Phillimore
coleenp at openjdk.org
Wed Dec 3 20:28:59 UTC 2025
On Wed, 3 Dec 2025 14:04:28 GMT, Anton Artemov <aartemov at openjdk.org> wrote:
>> Hi,
>>
>> please consider the following changes:
>>
>> In this PR `Thread::SpinAcquire()` and `Thread::SpinRelease()` methods are refactored into a utility class `SpinCriticalSection`. The motivation is to make it easier for developers to use this lightweight synchronization mechanism in the codebase. The two aforementioned methods were used in JFR to create short critical sections with a helper class, but that was not the case for the object monitor code.
>>
>> Tested in tiers 1 - 5.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8366671: Added NoSafepointVerifier
The NSV addition seems okay. I was afraid it would be messier than it turned out to be. Thanks.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28264#pullrequestreview-3536796538
More information about the hotspot-dev
mailing list