RFR: 8366671: Refactor Thread::SpinAcquire and Thread::SpinRelease [v12]

Coleen Phillimore coleenp at openjdk.org
Thu Dec 4 12:35:40 UTC 2025


On Thu, 4 Dec 2025 08:31:33 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8366671: Added NoSafepointVerifier
>
> src/hotspot/share/utilities/spinCriticalSection.hpp line 46:
> 
>> 44:   // compared to  smaller/larger types.
>> 45:   volatile int* const _lock;
>> 46:   DEBUG_ONLY(NoSafepointVerifier _nsv;)
> 
> I thought NSV had to be used as a StackObj ?? I don't understand why it is a field of SCS.

It can be a field of a StackObj too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28264#discussion_r2588894187


More information about the hotspot-dev mailing list