RFR: 8373114: Redundant MethodCounters in the preimage generated by training run

[Ashutosh Mehra]

On Thu, 4 Dec 2025 23:02:05 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

> I'm not an expert in CDS, but the fix doesn't look right. It breaks Metadata traversal CDS relies on. Instead, if you don't want to keep around MethodCounters not linked to MTDs, break the link from Method (Method::_method_counters) before dumping pre-image and restore it from archived TrainingDataSet during assembly phase.

Right, this is not the correct fix. It breaks the Method->MethodCounters link for all the methods. We need to preserve the links for the MethodCounters that get added through MTD.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28670#issuecomment-3614766014