RFR: 8366671: Refactor Thread::SpinAcquire and Thread::SpinRelease [v14]

Coleen Phillimore coleenp at openjdk.org
Mon Dec 8 12:43:00 UTC 2025


On Mon, 8 Dec 2025 09:52:37 GMT, Anton Artemov <aartemov at openjdk.org> wrote:

>> Hi, 
>> 
>> please consider the following changes:
>> 
>> In this PR `Thread::SpinAcquire()` and `Thread::SpinRelease()` methods are refactored into a utility class `SpinCriticalSection`. The motivation is to make it easier for developers to use this lightweight synchronization mechanism in the codebase. The two aforementioned methods were used in JFR to create short critical sections with a helper class, but that was not the case for the object monitor code. 
>> 
>> Tested in tiers 1 - 5.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8366671: Use non-safe current_or_null.

I think sine the answer to my previous question is 'no', the unsafe version of thread_or_null is fine, and better.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28264#pullrequestreview-3551870959


More information about the hotspot-dev mailing list